From: | Ryan Kelly <rpkelly22(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: psql sets up cancel handler very early |
Date: | 2013-05-14 15:41:49 |
Message-ID: | 20130514154149.GD15128@llserver.lakeliving.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I submitted essentially this same patch over a year ago and Tom vetoed
it: http://www.postgresql.org/message-id/3741.1325731017@sss.pgh.pa.us
The thread moved to -hackers at some point and I made some further
enhancements: http://www.postgresql.org/message-id/20120108201802.GA31348@llserver.lakeliving.com
Never went anywhere though.
-Ryan P. Kelly
On Tue, May 05/14/13, 2013 at 11:35:36AM -0400, Peter Eisentraut wrote:
> Sometimes, the psql startup hangs when it cannot resolve or connect to a
> host. Intuitively, I would like to press Ctrl+C and correct the
> connection string or investigate. But that doesn't work because Ctrl+C
> is already bound to the query cancel handler by that time.
>
> It seems to me that there is no point in setting up the cancel handler
> before the database connection is established. Example patch attached.
> Comments?
> diff --git a/src/bin/psql/startup.c b/src/bin/psql/startup.c
> index 5d7fe6e..65a1cde 100644
> --- a/src/bin/psql/startup.c
> +++ b/src/bin/psql/startup.c
> @@ -111,8 +111,6 @@ static void parse_psql_options(int argc, char *argv[],
> setvbuf(stderr, NULL, _IONBF, 0);
> #endif
>
> - setup_cancel_handler();
> -
> pset.progname = get_progname(argv[0]);
>
> pset.db = NULL;
> @@ -249,6 +247,8 @@ static void parse_psql_options(int argc, char *argv[],
> exit(EXIT_BADCONN);
> }
>
> + setup_cancel_handler();
> +
> PQsetNoticeProcessor(pset.db, NoticeProcessor, NULL);
>
> SyncVariables();
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
From | Date | Subject | |
---|---|---|---|
Next Message | Benedikt Grundmann | 2013-05-14 16:09:19 | Re: streaming replication, "frozen snapshot backup on it" and missing relfile (postgres 9.2.3 on xfs + LVM) |
Previous Message | Heikki Linnakangas | 2013-05-14 15:39:50 | Re: commit fest schedule for 9.4 |