Re: Strange Windows problem, lock_timeout test request

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Hari Babu <haribabu(dot)kommi(at)huawei(dot)com>, 'Craig Ringer' <craig(at)2ndQuadrant(dot)com>, 'Hans-Jürgen Schönig' <hs(at)cybertec(dot)at>, 'Ants Aasma' <ants(at)cybertec(dot)at>, 'PostgreSQL Hackers' <pgsql-hackers(at)postgresql(dot)org>, 'Amit kapila' <amit(dot)kapila(at)huawei(dot)com>
Subject: Re: Strange Windows problem, lock_timeout test request
Date: 2013-03-16 17:48:35
Message-ID: 20130316174835.GQ4361@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Boszormenyi Zoltan (zb(at)cybertec(dot)at) wrote:
> Stephen Frost was against the array pointer/count variant,
> it was done that way earlier. Let me redo it again. :-)

I still don't particularly like the array approach, and see the
array+count approach as worse (seems like a higher chance that the count
will end up being wrong at some point than having an array termination
identifier). I still like the List approach, as that builds on a
structure we've already got and can take advantage of the existing
infrastructure. but Tom's got a good point regarding the potential for
memory leaks with that solution.

I havn't had a chance to look, but I would have expected the Lists for
these to be allocated in a per-statement context, which would address
the memory leak issue. Perhaps that isn't possible though. I agree
that the List construct doesn't particularly help the callers, though I
do think it makes the enable_timeouts() function cleaner.

Thanks,

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-03-16 18:04:25 Re: Strange Windows problem, lock_timeout test request
Previous Message Boszormenyi Zoltan 2013-03-16 17:17:00 Re: Strange Windows problem, lock_timeout test request