Re: 9.2.3 crashes during archive recovery

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: kondo(dot)mitsumasa(at)lab(dot)ntt(dot)co(dot)jp
Cc: hlinnakangas(at)vmware(dot)com, michael(dot)paquier(at)gmail(dot)com, ants(at)cybertec(dot)at, simon(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: 9.2.3 crashes during archive recovery
Date: 2013-03-06 05:14:22
Message-ID: 20130306.141422.147305738.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, I suppose the attached patch is close to the solution.

> I think that this is an original intention of Heikki's patch.

I noticed that archive recovery will be turned on in
next_record_is_invalid thanks to your patch.

> On the other hand, your patch fixes that point but ReadRecord
> runs on the false page data. However the wrong record on the
> false page can be identified as broken, It should be an
> undesiable behavior.

All we should do to update minRecoveryPoint as needed when
XLogPageRead is failed in ReadRecord is to simply jump to
next_record_is_invalid if archive recovery is requested but doing
crash recovery yet.

Your modification in readTimeLineHistory and my modifictions in
XLogPageRead seem not necessary for the objective in this thread,
so removed.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
923crash-20130306.patch text/x-patch 777 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2013-03-06 07:50:07 Re: 9.2.3 crashes during archive recovery
Previous Message Michael Paquier 2013-03-06 05:08:06 Re: Request for vote to move forward with recovery.conf overhaul