Re: Strange Windows problem, lock_timeout test request

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Hari Babu <haribabu(dot)kommi(at)huawei(dot)com>, 'Craig Ringer' <craig(at)2ndQuadrant(dot)com>, 'Hans-Jürgen Schönig' <hs(at)cybertec(dot)at>, 'Ants Aasma' <ants(at)cybertec(dot)at>, 'Tom Lane' <tgl(at)sss(dot)pgh(dot)pa(dot)us>, 'PostgreSQL Hackers' <pgsql-hackers(at)postgresql(dot)org>, 'Amit kapila' <amit(dot)kapila(at)huawei(dot)com>
Subject: Re: Strange Windows problem, lock_timeout test request
Date: 2013-02-24 03:15:08
Message-ID: 20130224031508.GB16142@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Andrew Dunstan (andrew(at)dunslane(dot)net) wrote:
> Every unified diff can be turned into a context diff by passing it
> though "filterdiff --format=context".

On that point, annoyingly, it's not accurate for every diff. In
particular, when I tried it with the diff for 'v29' of this lock_timeout
patch, it only returns the context diff for the first two files:

zcat 2-lock_timeout-v29.patch.gz | grep -- '--- postgresql' | wc -l
22

zcat 2-lock_timeout-v29.patch.gz | \
filterdiff --format=context | \
grep '\*\*\* postgresql' | wc -l
2

In the end, I did create a local git branch, commit the patch, then
diff it back against master using my context-diff git helper to get
something easier to read through. Rather annoying.

Thanks,

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2013-02-24 05:55:51 Re: bugfix: --echo-hidden is not supported by \sf statements
Previous Message Stephen Frost 2013-02-24 03:07:15 Re: bugfix: --echo-hidden is not supported by \sf statements