Re: inconsistent time zone formats in log

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: inconsistent time zone formats in log
Date: 2012-12-29 12:43:11
Message-ID: 20121229124311.GA29478@alap2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2012-12-29 07:23:24 -0500, Peter Eisentraut wrote:
> The xlog code uses two different time zone formats at various times.
> Here is an example:
>
> 2012-12-29 07:04:07.338 EST LOG: database system was interrupted; last known up at 2012-12-29 06:27:02 EST
> 2012-12-29 07:04:26.347 EST LOG: last completed transaction was at log time 2012-12-29 06:34:24.394802-05
>
> The second format also does not respect log_timezone, which seems a bit
> of a bug.
>
> It's also not clear why we need three different ways to show
> milliseconds within the space of two lines.

One is a pg_time_t (stored in pg_control/ControlFileData), the other is
a TimestampTz. Those have completely different code paths for being
printed (pg_strftime vs EncodeDateTime) ...
I don't want to say its impossible or shouldn't be fixed, just that its
not trivial to do so.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-12-29 12:48:36 Re: Event Triggers: adding information
Previous Message Peter Eisentraut 2012-12-29 12:23:24 inconsistent time zone formats in log