From: | Christoph Berg <christoph(dot)berg(at)credativ(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: configure.in and setproctitle/optreset problem |
Date: | 2012-12-19 10:08:08 |
Message-ID: | 20121219100807.GB32111@msgid.credativ.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Re: Tom Lane 2012-12-18 <8705(dot)1355845633(at)sss(dot)pgh(dot)pa(dot)us>
> > The correct fix, IMO/IIRC, is to add LDFLAGS=-Wl,--as-needed before
> > running most of the configure checks, instead of after.
>
> Meh. It's not clear to me at all that that fixes the issue here,
> or at least that it does so in any way that's reliable. The proposal
> to add --as-needed during configure was made to fix a different problem,
> namely making the wrong decision about whether libintl needs to be
> pulled in explicitly. We don't seem to have done anything about that
To me, twiddling with --as-needed sounds like trading one set of
possible problems for a different one, configure checks should be as
deterministic as possible. It might still be that Peter's --as-needed
suggestion is a good fix, but I believe the issue I reported should
also be fixed by the patch Tom sent.
Reiterating a point from my original message, why is -l{readline,edit}
included in these configure checks at all? Most (if not all) of the
function checks in that block are not related to input editing anyway.
Mit freundlichen Grüßen,
Christoph Berg
--
Tel.: +49 (0)21 61 / 46 43-187
credativ GmbH, HRB Mönchengladbach 12080
Hohenzollernstr. 133, 41061 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2012-12-19 13:28:49 | Re: [WIP] pg_ping utility |
Previous Message | Groshev Andrey | 2012-12-19 09:51:08 | Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1 |