Re: Re: [PATCH 02/14] Add support for a generic wal reading facility dubbed XLogReader

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [PATCH 02/14] Add support for a generic wal reading facility dubbed XLogReader
Date: 2012-12-13 15:44:43
Message-ID: 20121213154443.GC4451@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas wrote:
> On 11.12.2012 21:11, Andres Freund wrote:
> >Now that I have read some of that code, I am currently unsure how the
> >current implementation of this can cooperate with translation, even when
> >used from the backend?
>
> Hmm, there was a gettext() call missing from report_invalid_record.
> That's where the translation needs to happen. Fixed now.

You need to call gettext_noop() in the string literals as well, unless
you've added the function and argument number to the gettext trigger
list in nls.mk.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message 李海龙 2012-12-13 15:46:15 I s this a bug of spgist index in a heavy write condition?
Previous Message Peter Geoghegan 2012-12-13 15:31:06 Re: [PERFORM] encouraging index-only scans