Re: Re: [PATCH 02/14] Add support for a generic wal reading facility dubbed XLogReader

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Peter Geoghegan <peter(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [PATCH 02/14] Add support for a generic wal reading facility dubbed XLogReader
Date: 2012-12-11 23:58:25
Message-ID: 20121211235825.GA9558@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2012-12-11 22:52:09 +0000, Peter Geoghegan wrote:
> On 11 December 2012 22:24, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > TBH, I don't believe that ordinary users will need this tool at all,
> > ever, and thus I don't want it in src/bin/. From a packaging standpoint
> > it will be a lot easier if it's in contrib ... otherwise I'll probably
> > have to invent some new sub-RPM along the lines of postgresql-extras
> > so as to avoid bloating the core server package.
>
> I happen to agree that pg_xlogdump belongs in contrib

Ok, I think there has been clear support for putting it into contrib, I
can comfortably live with that even though I would prefer otherwise. So
lets concentrate on other things ;)

> pg_xlogdump is 141K on my system. I'd hate to see us embrace the exact
> opposite tendency, towards including everything but the kitchen sink,
> but at the same time that seems like a very insignificant size.
> Perhaps people who live in countries with less bandwidth care about
> these things more.

Optimized and stripped - which is what most distros do - it's 40k
here. Gzipped - as in packages - its only 20k on its own. So its even
smaller ;)

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-12-12 00:33:32 Re: Use of systable_beginscan_ordered in event trigger patch
Previous Message Greg Smith 2012-12-11 23:53:02 Re: [WIP PATCH] for Performance Improvement in Buffer Management