From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Re: [PATCH 02/14] Add support for a generic wal reading facility dubbed XLogReader |
Date: | 2012-12-11 15:44:36 |
Message-ID: | 20121211154436.GE5062@alap2.lan |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2012-12-11 16:43:12 +0100, Andres Freund wrote:
> On 2012-12-11 15:44:39 +0100, Andres Freund wrote:
> > On 2012-12-11 15:55:35 +0200, Heikki Linnakangas wrote:
> > > * It's pretty ugly that to use the rm_desc functions, you have to provide
> > > dummy implementations of a bunch of backend functions, including pfree() and
> > > timestamptz_to_str(). Should find a better way to do that.
> >
> > I think most of the cases requiring those ugly hacks can be fixed to
> > just use a caller-provided buffer, there's not that much left.
> >
> > timestamptz_to_str() is probably the most complex case. I just noticed
> > there's already a second implementation in
> > ecpg/pgtypeslib/dt_common.c. Yuck. It seems to already have diverged in
> > a number of cases :(
>
> The attached (and pushed) patches change relpathbackend to use a static buffer
> instead. That gets rid of the pfree() requirement and looks ok otherwise as
> well.
... really attached.
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0001-Make-relpathbackend-return-a-statically-result-inste.patch | text/x-patch | 15.0 KB |
0002-Remove-empty-pfree-definition-from-pg_xlogdump-compa.patch | text/x-patch | 876 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2012-12-11 16:37:02 | Re: [BUG?] lag of minRecoveryPont in archive recovery |
Previous Message | Andres Freund | 2012-12-11 15:43:12 | Re: Re: [PATCH 02/14] Add support for a generic wal reading facility dubbed XLogReader |