Re: Fix for pg_upgrade status display

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Fix for pg_upgrade status display
Date: 2012-12-07 17:26:37
Message-ID: 20121207172637.GA8889@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 5, 2012 at 10:04:53PM -0500, Bruce Momjian wrote:
> Pg_upgrade displays file names during copy and database names during
> dump/restore. Andrew Dunstan identified three bugs:
>
> * long file names were being truncated to 60 _leading_ characters, which
> often do not change for long file names
>
> * file names were truncated to 60 characters in log files
>
> * carriage returns were being output to log files
>
> The attached patch fixes these --- it prints 60 _trailing_ characters to
> the status display, and full path names without carriage returns to log
> files.

Patch applied. It also suppresses status output to the log file unless
verbose mode is used.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-12-07 18:11:32 Re: Proof of concept: auto updatable views [Review of Patch]
Previous Message Andres Freund 2012-12-07 17:19:31 Re: Support for REINDEX CONCURRENTLY