| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | peter_e(at)gmx(dot)net |
| Cc: | laurenz(dot)albe(at)wien(dot)gv(dot)at, ishii(at)postgresql(dot)org, jianggq(at)cn(dot)fujitsu(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Patch to fix a crash of psql |
| Date: | 2012-11-30 16:55:39 |
| Message-ID: | 20121201.015539.1981741386316893807.t-ishii@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I think the message should be more precise. Nobody will know what an
> "encoding conflict" is. The error condition is "last multibyte
> character ran over end of file" or something like that, which should be
> clearer.
"last multibyte character ran over" is not precise at all because the
error was caused by each byte in the file confused PQmblen, not just
last multibyte character. However to explain those in the messgae is
too technical for users, I'm afraid. Maybe just "encoding mismatch
detected. please make sure that input file encoding is SJIS" or
something like that?
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2012-11-30 16:57:07 | Re: WIP json generation enhancements |
| Previous Message | Tatsuo Ishii | 2012-11-30 16:48:04 | Re: [PATCH] Patch to fix a crash of psql |