From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Enabling frontend-only xlog "desc" routines |
Date: | 2012-11-27 18:46:35 |
Message-ID: | 20121127184635.GM4227@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I mentioned the remaining issues in a previous email (see
message-id 20121025161751(dot)GE6442(at)alvh(dot)no-ip(dot)org). Attached is a
patch that enables xlogdump to #include xlog_internal.h by way of
removing that file's inclusion of fmgr.h, which is problematic. I don't
think this should be too contentious.
The other interesting question remaining is what to do about the rm_desc
function in rmgr.c. We're split between these two ideas:
1. Have this in rmgr.c:
#ifdef FRONTEND
#define RMGR_REDO_FUNC(func) NULL
#else
#define RMGR_REDO_FUNC(func) func
#endif /* FRONTEND */
and then use RMGR_REDO_FUNC() in the table.
2. Have this in rmgr.c:
#ifndef RMGR_REDO_FUNC
#define RMGR_REDO_FUNC(func) func
#endif
And then have the xlogdump Makefile use -D to define a suitable
RMGR_REDO_FUNC.
Opinions please?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
xlog-fn.patch | text/x-diff | 3.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2012-11-27 18:50:55 | Re: MySQL search query is not executing in Postgres DB |
Previous Message | Jeff Davis | 2012-11-27 18:45:21 | Re: MySQL search query is not executing in Postgres DB |