| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Boszormenyi Zoltan <zb(at)cybertec(dot)at> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Make pg_basebackup configure and start standby [Review] |
| Date: | 2012-11-21 13:19:44 |
| Message-ID: | 20121121131944.GA4210@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Boszormenyi Zoltan wrote:
> The problem is that it calls pg_malloc() which is an executable-specific
> function. Some of the bin/* executables define it as calling exit(1)
> when malloc() returns NULL, some call it with exit(EXIT_FAILURE)
> which happens to be 1 but still can be different from the constant 1.
> Some executables only define pg_malloc0() but not pg_malloc().
It seems simpler to have the escape_quotes utility function in port just
not use pg_malloc at all, have it return NULL or similar failure
indicator when malloc() fails, and then the caller decides what to do.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Albe Laurenz | 2012-11-21 13:34:25 | Re: ERROR: volatile EquivalenceClass has no sortref |
| Previous Message | Amit kapila | 2012-11-21 13:15:53 | Re: [WIP PATCH] for Performance Improvement in Buffer Management |