Re: Extend argument of OAT_POST_CREATE

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extend argument of OAT_POST_CREATE
Date: 2012-10-23 21:34:58
Message-ID: 20121023213458.GB6004@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kohei KaiGai escribió:

> 2012/10/10 Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:

> > I admit the new RELKIND_INDEX cases in various places make for strange
> > flow. Not sure how it can be improved though.
> >
> The idea is not so complicated. This code considers index is an
> property of a certain table like as individual field of pg_class.
> Relation is the most complex object in PostgreSQL. Its property
> is not only ones in pg_class, but some extra catalogs such as
> pg_trigger, pg_rewrite and so on.

I have pushed this patch with some slight changes in the way
the RELKIND_INDEX case is handled in various places, to make it
clearer. I may have broken some cases; please have a look.

Thanks.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Murphy, Kevin 2012-10-23 22:12:12 Re: Very minor feature suggestion
Previous Message Ants Aasma 2012-10-23 20:06:07 Re: ToDo: KNN Search should to support DISTINCT clasuse?