Re: 64-bit API for large object

From: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: 64-bit API for large object
Date: 2012-09-21 08:33:53
Message-ID: 20120921173353.27270e6cb437a5d6d123cfac@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> > Currently lo_initialize() throws an error if one of oids are not
> > available. I doubt we do the same way for 64-bit functions since this
> > will make 9.3 libpq unable to access large objects stored in pre-9.2
> > PostgreSQL servers.
> >
> It seems to me the situation to split the case of pre-9.2 and post-9.3
> using a condition of "conn->sversion >= 90300".
>

Agreed. I'll fix it like that.

> > 4) src/test/examples/testlo64.c added for 64-bit API example(Yugo Nagata)
> >
> > Comments and suggestions are welcome.
> >
> miscellaneous comments are below.
>
> Regression test is helpful. Even though no need to try to create 4TB large
> object, it is helpful to write some chunks around the design boundary.
> Could you add some test cases that writes some chunks around 4TB offset.

Agreed. I'll do that.

>
> Thanks,
> --
> KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message M.Sakamoto 2012-09-21 08:45:44 Re: pg_reorg in core?
Previous Message Kohei KaiGai 2012-09-21 08:25:43 Re: 64-bit API for large object