From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: 9.2 pg_upgrade regression tests on WIndows |
Date: | 2012-09-05 04:02:24 |
Message-ID: | 20120905040224.GA22912@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Sep 3, 2012 at 12:44:09PM -0400, Andrew Dunstan wrote:
> The attached very small patch allows pg_upgrade's "make check" to
> succeed on REL9_2_STABLE on my Mingw system.
>
> However, I consider the issue I mentioned earlier regarding use of
> forward slashes in the argument to rmdir to be a significant
> blocker, so I'm going to go and fix that and then pull this all
> together.
>
> cheers
>
> andrew
> diff --git a/contrib/pg_upgrade/exec.c b/contrib/pg_upgrade/exec.c
> index 6f993df..57ca1df 100644
> --- a/contrib/pg_upgrade/exec.c
> +++ b/contrib/pg_upgrade/exec.c
> @@ -91,10 +91,12 @@ exec_prog(bool throw_error, bool is_priv, const char *log_file,
> else
> retval = 0;
>
> +#ifndef WIN32
> if ((log = fopen_priv(log_file, "a+")) == NULL)
> pg_log(PG_FATAL, "cannot write to log file %s\n", log_file);
> fprintf(log, "\n\n");
> fclose(log);
> +#endif
>
> return retval;
> }
OK, I worked with Andrew on this issue, and have applied the attached
patch which explains what is happening in this case. Andrew's #ifndef
WIN32 was the correct fix. I consider this issue closed.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
Attachment | Content-Type | Size |
---|---|---|
log.diff | text/x-diff | 2.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-09-05 04:09:03 | Re: 9.2rc1 produces incorrect results |
Previous Message | Tom Lane | 2012-09-05 03:44:40 | Re: too much pgbench init output |