Re: getting carriage return character in vacuumo

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Martijn van Oosterhout <kleptog(at)svana(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Muhammad Usama <m(dot)usama(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: getting carriage return character in vacuumo
Date: 2011-09-06 21:23:20
Message-ID: 201109062123.p86LNKm13202@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Martijn van Oosterhout wrote:
-- Start of PGP signed section.
> On Fri, Apr 08, 2011 at 02:10:56PM -0400, Tom Lane wrote:
> > Muhammad Usama <m(dot)usama(at)gmail(dot)com> writes:
> > > While using the vacuumlo utility I encountered a redundant carriage
> > > return(\r') character in the output. It is required in any scenario? If not,
> > > please find attached a tiny patch which will get rid of that extra '\r'
> > > character.
> >
> > I think the idea there is to overwrite successive progress messages
> > on the same line. It's maybe not going to work in all environments,
> > though, so perhaps we should reconsider that bit of cuteness.
>
> One could hinge it on batch or non-batch mode, the default being
> determined by whether it's running in a terminal or not.

pg_upgrade also uses this \r status update trick unconfitionally.
Should we fix these?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-09-06 21:33:12 pgpass comment suggestion
Previous Message Tom Lane 2011-09-06 21:16:58 Re: timezone GUC