Re: Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Don't use "cp -i" in the example WAL archive_command.
Date: 2011-06-19 12:00:40
Message-ID: 201106191200.p5JC0ew08567@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Perhaps we should recommend:
> > cd /path && test ! -f %f && cp %p %f
> > That is shorter and removes the duplicate problem.
>
> Um ... %p is relative to the database directory.

Oh, I see now. I had thought it was an absolute path, but good thing it
isn't because of the possible need for quoting characters in the path
name.

The only other idea I have is:

NEW=/path && test ! -f $NEW/%f && cp %p $NEW/%f

but that is not going to work with csh-based shells, while I think the
original is fine.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message User Hinoue 2011-06-19 12:27:30 psqlodbc - psqlodbc: Fix compilation errors in case ODBC 2.5.
Previous Message User Hinoue 2011-06-19 05:03:23 psqlodbc - psqlodbc: Add some driver specific options for

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2011-06-19 12:03:51 Re: patch for 9.2: enhanced errors
Previous Message Florian Pflug 2011-06-19 11:43:43 Re: patch for 9.2: enhanced errors