Re: pgindent weirdnessf

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgindent weirdnessf
Date: 2011-04-20 17:59:53
Message-ID: 201104201759.p3KHxrw05220@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas wrote:
> On Wed, Apr 20, 2011 at 12:33 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> > You can contribute to the list by running a buildfarm animal on your machine
> > and running its find_typedefs occasionally. This is not just about me. I
> > have asked on numerous occasions for other people to contribute, and the
> > response has been deafening silence. The ?reason we got to this place is
> > that people complained that your list was insufficiently complete, so I
> > added a facility for buildfarm animals to generate their own lists, so we
> > could get wider platform coverage. So my response to anyone who says "well,
> > it works on my box" is "then why isn't your box doing it for the buildfarm?"
>
> This is all well and good up to a point, but if Bruce's ancient BSDi
> machine is the only one that can properly find these symbols, then we
> are courting disaster by relying on it, even if he does run a
> buildfarm animal there. I can't help thinking there must be some
> other explanation for this change.

Uh, just a reality check, but our "courting disaster" means we will have
an extra space after some asterisks in the source code. ;-)

I do, agree, though, it would be nice to find out what changed that
caused this.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2011-04-20 18:10:17 Re: pgbench \for or similar loop
Previous Message Peter Eisentraut 2011-04-20 17:56:46 Re: Formatting Curmudgeons WAS: MMAP Buffers