Re: Typed table DDL loose ends

From: Noah Misch <noah(at)leadboat(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Typed table DDL loose ends
Date: 2011-04-20 14:53:34
Message-ID: 20110420145334.GB31420@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 18, 2011 at 10:44:53PM +0300, Peter Eisentraut wrote:
> On Sat, 2011-04-09 at 21:57 -0400, Noah Misch wrote:
> > * Inheriting from a typed table blocks further type DDL
> > CREATE TYPE t AS (x int);
> > CREATE TABLE parent OF t;
> > CREATE TABLE child () INHERITS (parent);
> > ALTER TYPE t ADD ATTRIBUTE y int CASCADE;
> > -- ERROR: column must be added to child tables too
> > We ought to just set INH_YES on the downstream command in ATTypedTableRecursion.
> > If we get to that point, the user did choose ALTER TYPE CASCADE; it seems fair
> > to assume he'd want inheritance recursion rather than a later error.
>
> Agreed.

Patch attached for that. Apart from a comment, a test case and a doc update, it
turned out to be a one-liner.

Attachment Content-Type Size
tt3v1-typed-inherit-recurse.patch text/plain 5.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-04-20 15:05:43 Re: time-delayed standbys
Previous Message Merlin Moncure 2011-04-20 14:46:48 Re: pgbench \for or similar loop