Re: pg_basebackup for streaming base backups

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup for streaming base backups
Date: 2011-01-20 15:15:37
Message-ID: 201101201515.p0KFFbJ16538@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas wrote:
> On Thu, Jan 20, 2011 at 10:01 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Magnus Hagander wrote:
> >> On Mon, Jan 17, 2011 at 16:27, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> >> > On Mon, 2011-01-17 at 16:20 +0100, Magnus Hagander wrote:
> >> >> On Mon, Jan 17, 2011 at 16:18, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> >> >> > On Mon, Jan 17, 2011 at 8:55 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> >> >> >> Hmm. I don't like those names at all :(
> >> >> >
> >> >> > I agree. ?I don't think your original names are bad, as long as
> >> >> > they're well-documented. ?I sympathize with Simon's desire to make it
> >> >> > clear that these use the replication framework, but I really don't
> >> >> > want the command names to be that long.
> >> >>
> >> >> Actually, after some IM chats, I think pg_streamrecv should be
> >> >> renamed, probably to pg_walstream (or pg_logstream, but pg_walstream
> >> >> is a lot more specific than that)
> >> >
> >> > pg_stream_log
> >> > pg_stream_backup
> >>
> >> Those seem better.
> >>
> >> Tom, would those solve your concerns about it being clear which side
> >> they are on? Or do you think you'd still risk reading them as the
> >> sending side?
> >
> > It seems pg_create_backup would be the most natural because we already
> > have pg_start_backup and pg_stop_backup.
>
> Uh, wow. That's really mixing apples and oranges.

I read the description as:

+ You can also use the <xref linkend="app-pgbasebackup"> tool to take
+ the backup, instead of manually copying the files. This tool will take
+ care of the <function>pg_start_backup()</>, copy and
+ <function>pg_stop_backup()</> steps automatically, and transfers the
+ backup over a regular <productname>PostgreSQL</productname> connection
+ using the replication protocol, instead of requiring filesystem level
+ access.

so I thought, well it does pg_start_backup and pg_stop_backup, and also
creates the data directory.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-01-20 15:17:37 Re: sepgsql contrib module
Previous Message Robert Haas 2011-01-20 15:06:34 Re: pg_basebackup for streaming base backups