From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: duplicate connection failure messages |
Date: | 2010-11-19 19:43:33 |
Message-ID: | 201011191943.oAJJhXc17187@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Excerpts from Bruce Momjian's message of vie nov 19 00:17:59 -0300 2010:
> >> Alvaro Herrera wrote:
> >>> I think we should use inet_ntop where available to print the address.
> >>
> >> Good idea because inet_ntop() is thread-safe. Does that work on IPv6?
> >> You indicated that inet_ntoa() does not.
>
> > According to opengroup.org, IPv6 should work if the underlying libraries
> > support it, whereas inet_ntoa explicitely does not.
> > http://www.opengroup.org/onlinepubs/009695399/functions/inet_ntop.html
> > http://www.opengroup.org/onlinepubs/009695399/functions/inet_addr.html
>
> I get the impression that you guys have forgotten the existence of
> src/backend/utils/adt/inet_net_ntop.c
Yeah, that is nice, but we are calling this from libpq, not the backend.
Let me work up a patch.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
From | Date | Subject | |
---|---|---|---|
Next Message | Dimitri Fontaine | 2010-11-19 19:44:06 | Re: directory archive format for pg_dump |
Previous Message | Andres Freund | 2010-11-19 19:33:45 | Re: Latches with weak memory ordering (Re: max_wal_senders must die) |