| From: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fillfactor gets set to zero for toast tables |
| Date: | 2010-06-04 04:08:01 |
| Message-ID: | 20100604130800.9993.52131E4D@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
> Could you explain why default_only entries idea is
> better than adjusting those fields in the toast-specific codes?
> It's my understanding that reloption-framework is just a tool to fill
> reloption parameters, and it's not responsible for unused fields.
Here is my proposal to fix the issue. I didn't introduce default_only
field but simply adjust parameters for TOAST reloptions.
BTW, not only heap and toast relations but also btree, hash, and gist
indexes use StdRdOptions. However, they actually don't support autovacuum
options. So, StdRdOptions is a bloated all-in-one descriptor now.
Instead, they should use fillfactor-only reloptions that is defined
separately from options for heap.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| toast-default-only-relopts.patch | application/octet-stream | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | KaiGai Kohei | 2010-06-04 04:17:38 | Re: [PATCH] Fix leaky VIEWs for RLS |
| Previous Message | Andrew Dunstan | 2010-06-04 03:15:08 | hot_standby = on |