Re: Add column if not exists (CINE)

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Kjell Rune Skaaraas <kjella79(at)yahoo(dot)no>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add column if not exists (CINE)
Date: 2010-04-30 13:42:48
Message-ID: 201004301342.o3UDgmC18052@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > We can artificially make this problem as complicated as we wish, but
> > the people who are asking for this feature (including me) will, I
> > believe, be quite happy with a solution that throws, say, a NOTICE
> > instead of an ERROR when the object already exists, and then returns
> > without doing anything further. There are very few, if any,
> > definitional issues here, except by people who are brainstorming crazy
> > alternative behaviors whose actual usefulness I very much doubt.
>
> > CREATE OR REPLACE is indeed much more complicated. In fact, for
> > tables, I maintain that you'll need to link with -ldwim to make it
> > work properly.
>
> This may in fact be an appropriate way to handle the case for tables,
> given the complexity of their definitions. However, the original
> point of the thread was about what to do for columns. I still say
> that COR rather than CINE semantics would be appropriate for columns.

I have added this TODO item:

Allow CREATE TABLE to optionally create a table if it does not already
exist, without throwing an error

The fact that tables contain data makes this more complex than other
CREATE OR REPLACE operations.

* http://archives.postgresql.org/pgsql-hackers/2010-04/msg01300.php

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-04-30 14:25:55 Re: missing file in git repo
Previous Message Robert Haas 2010-04-30 12:08:11 Re: Invalidating dependent views and functions