From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Michael Tharp <gxti(at)partiallystapled(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [RFC] nodeToString format and exporting the SQL parser |
Date: | 2010-04-25 01:18:10 |
Message-ID: | 201004250118.o3P1IAr24110@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Robert Haas wrote:
> On Sat, Apr 24, 2010 at 9:08 PM, Michael Tharp
> <gxti(at)partiallystapled(dot)com> wrote:
> > The funny thing is, it doesn't seem to be a compatibility break because the
> > code in readfuncs.c that parses the node strings ignores the field names
> > entirely because it assumes they are in a particular order. It also isn't
> > much work to change the output because the code is, with the exception of a
> > few weirdos, all at the top of outfuncs.c, and the weirdos are also
> > dispersed within that file.
>
> Yeah, I think that's basically all true.
>
> > However, I'm no longer convinced that using a serialized node tree is the
> > way to go for my use case, nor am I particularly sure that it even matches
> > my use case at all anymore as I keep simplifying the goals as time goes on.
> > I won't be able to make any compelling arguments until I figure out what I
> > need :-)
>
> However this is, as you say, a fairly damning point. :-)
>
> Bruce, I think we should not have a TODO for this until the OP (or
> someone) can address this issue a bit better.
OK, removed.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-04-25 01:37:31 | Re: global temporary tables |
Previous Message | Robert Haas | 2010-04-25 01:16:50 | Re: [RFC] nodeToString format and exporting the SQL parser |