Re: Buffer usage in EXPLAIN and pg_stat_statements (review)

From: Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Euler Taveira de Oliveira <euler(at)timbira(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Buffer usage in EXPLAIN and pg_stat_statements (review)
Date: 2009-10-15 01:19:15
Message-ID: 20091015101614.A2BD.52131E4D@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> > Well, you need to find another way or risk getting the patch rejected
> > altogether. ?Those global variables are the weakest part of the whole
> > design, and I'm not going to commit a patch that destabilizes the entire
> > system for the sake of a debatable "requirement" of a contrib module.
>
> I am marking this patch as Returned with Feedback. I hope that it
> will be resubmitted for a future CommitFest, because I think this
> could be pretty interesting feature.

Ok, I'll reconsider them and re-submit patches for the next commitfest.
Maybe I need to split the patch into EXPLAIN-part and contrib-part.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-10-15 01:19:43 Re: Reworks for Access Control facilities (r2363)
Previous Message Robert Haas 2009-10-15 01:08:50 Re: Reworks for Access Control facilities (r2363)