Re: Patch: create or replace language

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Andreas 'ads' Scherbaum <adsmail(at)wars-nicht(dot)de>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: create or replace language
Date: 2009-10-06 14:24:50
Message-ID: 20091006142450.GE5929@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andreas 'ads' Scherbaum wrote:
>
> Hello,
>
> following this old discussion:
>
> http://archives.postgresql.org/pgsql-patches/2008-03/msg00402.php
>
> i modifies the patch to use the "CREATE [OR REPLACE] LANGUAGE" syntax.
> If the patch is ok, i will add the documentation too.

Please send a context diff (however much ED IS THE STANDARD!!! TEXT
EDITOR, we don't like its patches here). Note that you probably missed
updates to other functions touching the node to which you add the
boolean. Also, per Tom's followup,

> Index: src/include/nodes/parsenodes.h
> ===================================================================
> RCS file: /projects/cvsroot/pgsql/src/include/nodes/parsenodes.h,v
> retrieving revision 1.402
> diff -r1.402 parsenodes.h
> 1570a1571
> > bool replace; /* T => replace if already exists */

this comment needs fixed.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2009-10-06 14:26:39 Re: [PATCH] DefaultACLs
Previous Message Tom Lane 2009-10-06 14:13:54 Re: Patch: create or replace language