| From: | Dan Colish <dan(at)unencrypted(dot)org> |
|---|---|
| To: | Emmanuel Cecchet <manu(at)asterdata(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Emmanuel Cecchet <Emmanuel(dot)Cecchet(at)asterdata(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: generic copy options |
| Date: | 2009-09-17 22:20:40 |
| Message-ID: | 20090917222040.GD13715@funkstrom.spiretech.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I have read through the patch a few times and it looks OK. The
additions to the COPY syntax work as expected and as agreed upon
based on the thread. Below are some points from my checklist.
- Patch applies cleanly
- Included new tests and documentation
- Well commented
- Documentation is clearly written
- Produced no error or warning on compile
- When compiled passes all tests
- Syntax works as expected
- Performance appears to be the same although I don't have a good way for
testing this at the moment
- Patch integrates well with current backend copy functions
- Patch cleanly extends the psql \copy feature
Any further thoughts on this patch? I think its pretty much ready.
--
--Dan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2009-09-17 22:21:30 | Re: gcc versus division-by-zero traps |
| Previous Message | Bruce Momjian | 2009-09-17 22:13:33 | Re: [COMMITTERS] pgsql: CVS NULL Documentation Clearify documentation of CVS's output of |