| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Filtering dictionaries support and unaccent dictionary |
| Date: | 2009-08-01 04:35:07 |
| Message-ID: | 20090801043507.GG11098@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Teodor Sigaev wrote:
> >As for the contrib module, I think it could use a lot more function
> >header comments! Also, it would be great if it could be used separately
> >from tsearch, i.e. that it provided a function unaccent(text) returns
> >text that unaccented arbitrary strings (I guess it would use the default
> >tsconfig).
> Umm? Module provides unaccent(text) and unaccent(regdictionary, text) functions.
Sorry, I failed to notice. Looks good.
Isn't that function leaking "res" pointer? Also, I'm curious why you're
allocating 2*sizeof(TSLexeme) in unaccent_lexize ...
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PFC | 2009-08-01 07:37:11 | Re: More thoughts on sorting |
| Previous Message | Robert Haas | 2009-08-01 04:18:46 | Re: machine-readable explain output v2 |