Re: Feedback on writing extensible modules

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndQuadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Feedback on writing extensible modules
Date: 2009-06-01 16:23:22
Message-ID: 20090601162322.GC5716@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dimitri Fontaine wrote:

> Le 31 mai 09 à 18:21, Tom Lane a écrit :

>> You could maybe make this work by executing your own transaction
>> to do it, but I really have to wonder if it's a good idea. One
>> point to think about is that elog(ERROR) still means elog(FATAL)
>> at this point, so any brokenness in the queries you're trying to
>> prepare will result in locking all users out of the database.
>
> Yeah that's a pretty good foot gun, yet another one. But
> preprepare.at_init is optional and defaults to off. If you broke it all,
> you can turn it off again and reload.

Maybe you could set a callback to be called during the first transaction
in InitPostgres ... in full knowledge that if it fails, people will be
locked out of the database.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-06-01 16:32:20 It's June 1; do you know where your release is?
Previous Message Bruce Momjian 2009-06-01 16:02:48 Re: pg_migrator and an 8.3-compatible tsvector data type