Re: Win32 link() function

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Win32 link() function
Date: 2009-06-01 04:14:50
Message-ID: 200906010414.n514Eor24135@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > Tom Lane wrote:
> > >> (Come to think of it, --link can fail on Unix too, if the user tries to
> > >> put the new database on a different filesystem. Have you got guards in
> > >> there to make sure this is discovered before the point of no return?)
> >
> > > Of course:
> > > ...
> > > though you have to delete the new cluster directory and remove the _old
> > > suffixes to get your old cluster back.
> >
> > That wasn't what I had in mind by "before the point of no return".
> > You should be making some effort to detect obvious failure cases
> > *before* the user has to do a lot of error-prone manual cleanup.
>
> That is something I will address during beta as I get problem reports.

I have added that as a TODO.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2009-06-01 05:47:36 pg_standby -l might destory the archived file
Previous Message Bruce Momjian 2009-06-01 04:09:42 Re: Win32 link() function