Duplicate code in psql's \ commands

From: David Fetter <david(at)fetter(dot)org>
To: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Duplicate code in psql's \ commands
Date: 2009-04-19 16:45:30
Message-ID: 20090419164530.GP10700@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Folks,

While working on the new improved \df, I noticed a pretty major
infelicity, namely that \ commands get validated by two completely
independent code paths, namely tab-complete.c and
command.c/describe.c.

I'm thinking it would be a good idea to factor the validating out as
far as possible. This would also make it easier to make sure that tab
completion and \'s output match to the maximal reasonable extent.

Objections?

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2009-04-19 17:18:32 Re: Replacing plpgsql's lexer
Previous Message Tom Lane 2009-04-19 16:42:44 Re: Replacing plpgsql's lexer