Re: Updates of SE-PostgreSQL 8.4devel patches (r1389)

Alvaro Herrera wrote:
> Tom Lane wrote:
>
> > I guess I'm still wondering which part of this actually needs to be
> > hand-coded so that it can be flexible. I'm envisioning the whole
> > loop replaced by something like
> >
> > FillRelOptions((void *) rdopts, options, &constanttable);
> >
> > where the constant table contains entries like
> >
> > { "fillfactor", RELOPT_TYPE_INT, offsetof(StdRdOptions, fillfactor) }
>
> I attach a patch that does things this way (it includes the btree test
> code because I'm too lazy right now to strip it out).

The irony of doing things this way is that we've come full-circle from
the original coding of these routines (the main difference being that
the default values and checks no longer need to be written as code, but
rather as table entries).

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.