Re: Block-level CRC checks

Jonah H. Harris escribió:
> On Sun, Dec 14, 2008 at 4:51 PM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
> >>> v11 doesn't apply to cvs head anymore
> >>
> >> I'm not currently working on this patch, sorry.
> >>
> >
> > Should we pull it from 8.4, then?
>
> Here's an updated patch against head.

Thanks.

> NOTE, it appears that this (and the previous) patch PANIC with
> "concurrent transaction log activity while database system is shutting
> down" on shutdown if checksumming is enabled. This appears to be due
> to FlushBuffer (lines 1821-1828) during the checkpoint-at-shutdown.

Yeah, I reported this issue several times.

> Similarly, I ran a pgbench, performed a manual checkpoint, and
> corrupted the tellers table myself using hexedit but the system didn't
> pick up the corruption at all :(

Heh :-)

> Alvaro, have you given up on the patch or are you just busy on
> something else at the moment?

I've given up until we find a good way to handle hint bits. Various
schemes have been proposed but they all have more or less fatal flaws.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.