Re: autovacuum and reloptions

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: autovacuum and reloptions
Date: 2008-10-08 15:10:22
Message-ID: 20081008151022.GB4164@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > On second look, however, the problem is that I seem to be
> > forced to declare all the autovacuum-related options and their parsing
> > properties in reloptions.c. This seems very ugly.
>
> That was in fact the intended design, and is why the functions exist in
> a separate file reloptions.c rather than having been dumped into some
> existing place like heapam.c. I don't see anything very wrong with
> having autovacuum options in StdRdOptions and default_reloptions().

Hmm, OK. However, given that the various AMs amoptions also use
default_reloptions, they are going to accept the autovacuum options too.
Is that OK?

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-10-08 15:34:40 Re: autovacuum and reloptions
Previous Message Tom Lane 2008-10-08 14:57:53 Re: autovacuum and reloptions