Re: pgwin32_safestat weirdness

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pgwin32_safestat weirdness
Date: 2008-04-13 17:16:41
Message-ID: 20080413191641.302e4fb3@mha-laptop
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan wrote:
>
> I'm confused about the current state of the pgwin32_safestat stuff.
> Cygwin is now building happily, but MinGW is now broken on libpq. It
> looks like libpq now needs dirmod.o or maybe libpgport.a. What I
> really don't understand though is why MinGW is broken but MSVC isn't.

I don't know why MSVC survives that without digging deeper, but the
original patch had the redefine only if !defined(FRONTEND), but that
seems to have been lost in Toms fix and it's now always redefined.

Tom - was there a reason it now runs in FRONTEND as well, or was that
an oversight?

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-04-13 17:20:20 Re: pgwin32_safestat weirdness
Previous Message Andrew Dunstan 2008-04-13 17:10:30 pgwin32_safestat weirdness