pgbouncer - pgbouncer: More magic cleanup, found even couple potential

From: mkz(at)pgfoundry(dot)org (User Mkz)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgbouncer - pgbouncer: More magic cleanup, found even couple potential
Date: 2007-08-13 20:37:11
Message-ID: 20070813203711.B85922171CD@pgfoundry.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
More magic cleanup, found even couple potential bugs.

- get_header() allowed < 5 length, which could trigger unsigned overflow.
- error from server when setting parameters did not do "return false"
- broken ParameterStatus should close connection.

Again, thanks to David Fetter who pushed for cleaner code.

Modified Files:
--------------
pgbouncer/src:
admin.c (r1.15 -> r1.16)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgbouncer/pgbouncer/src/admin.c.diff?r1=1.15&r2=1.16)
bouncer.h (r1.11 -> r1.12)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgbouncer/pgbouncer/src/bouncer.h.diff?r1=1.11&r2=1.12)
client.c (r1.13 -> r1.14)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgbouncer/pgbouncer/src/client.c.diff?r1=1.13&r2=1.14)
proto.c (r1.7 -> r1.8)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgbouncer/pgbouncer/src/proto.c.diff?r1=1.7&r2=1.8)
server.c (r1.11 -> r1.12)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgbouncer/pgbouncer/src/server.c.diff?r1=1.11&r2=1.12)
takeover.c (r1.4 -> r1.5)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgbouncer/pgbouncer/src/takeover.c.diff?r1=1.4&r2=1.5)

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2007-08-14 06:50:32 Re: pgsql: Fix two bugs induced in VACUUM FULL byasync-commit patch.
Previous Message Tom Lane 2007-08-13 19:27:12 pgsql: TEMPORARILY make synchronous_commit default to OFF, so that we