contrib/spi makefile inconsistency

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: contrib/spi makefile inconsistency
Date: 2007-03-22 14:18:55
Message-ID: 20070322141855.GD5635@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Hi!

contrib/spi has a Makefile that uses $(addsuffix) makefile rules for
DATA_built and DOCS. It's the only Makefile in contrib that does it.

I would like to change that to actually listing the modules instead. The
reason for that is that parsing the Makefile for the msvc build will be a
*lot* easier if I don't have to parse $addsuffix rules. And it's not like
it's complex modules it's building.

But I figured I'd post here for approval first. So - would a patch like the
attached be acceptable?

(Again, this only applies to contrib/SPI, I don't *expect* there to be more
such requirements for the other ones)

//Magnus

Attachment Content-Type Size
contrib.patch text/plain 1.2 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-03-22 14:41:46 Re: [HACKERS] Stats processor not restarting
Previous Message Jan Wieck 2007-03-22 13:23:54 Re: [PATCHES] As proposed the complete changes to pg_trigger and pg_rewrite