From: | Joachim Wieland <joe(at)mcknight(dot)de> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: guc patch: Make variables fall back to default values |
Date: | 2007-03-10 22:47:20 |
Message-ID: | 20070310224720.GA14588@mcknight.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
On Sat, Mar 10, 2007 at 09:35:38PM +0100, Peter Eisentraut wrote:
> This patch makes, in its source code comments and error messages, overly
> enthusiastic references to the fact that a parameter setting was
> supposedly "commented". The only information that is really available,
> however, is that the parameter setting disappeared from the
> configuration file, and we should not be making other claims.
Okay, this is an easy fix.
> Another issue that strikes me is that the GUC code apparently makes
> mixed used of palloc and guc_malloc, and this patch continues that.
True, there is some confusion in the GUC code about what allocation routine
should be used. I tried to use the same allocation method as an
already-existing similar allocation.
To lessen this confusion, can you do some cleanup work on the current GUC
code in this area that I can use as a basis for a revised version of the
patch?
Did you also do tests on the functional aspects of the patch?
Joachim
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-03-10 23:08:12 | Re: simply custom variables protection |
Previous Message | Simon Riggs | 2007-03-10 22:10:51 | Re: [PATCHES] scan_recycle_buffers |