From: | mark(at)mark(dot)mielke(dot)cc |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Gregory Stark <stark(at)enterprisedb(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Plan for compressed varlena headers |
Date: | 2007-02-15 17:39:18 |
Message-ID: | 20070215173918.GA23446@mark.mielke.cc |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Feb 15, 2007 at 10:42:49AM -0500, Tom Lane wrote:
> > #define VARDATA_4B(PTR) ((PTR)->va_4byte.va_data)
> > #define VARDATA_2B(PTR) ((PTR)->va_2byte.va_data)
> > #define VARDATA_1B(PTR) ((PTR)->va_1byte.va_data)
> I thought we had abandoned the 2-byte-header variant? Maybe you need to
> start a separate thread about exactly which of the bit-level proposals
> you want to implement. There were quite a few tradeoffs discussed in
> the previous thread IIRC.
I agreed with Tom in the last thread. The 2 byte case doesn't seem like
good value for the return.
Simpler analysis results in easier to optimize code for the compiler,
and less complexity stored on disk.
Please remove 2B. :-)
Cheers,
mark
--
mark(at)mielke(dot)cc / markm(at)ncf(dot)ca / markm(at)nortel(dot)com __________________________
. . _ ._ . . .__ . . ._. .__ . . . .__ | Neighbourhood Coder
|\/| |_| |_| |/ |_ |\/| | |_ | |/ |_ |
| | | | | \ | \ |__ . | | .|. |__ |__ | \ |__ | Ottawa, Ontario, Canada
One ring to rule them all, one ring to find them, one ring to bring them all
and in the darkness bind them...
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2007-02-15 17:54:15 | Re: automatic password for pg_dump to be used for a batch file in vb6 |
Previous Message | Gregory Stark | 2007-02-15 17:23:21 | Re: Plan for compressed varlena headers |