pgsql: Marginal cleanup in arrangements for ensuring StrategyHintVacuum

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Marginal cleanup in arrangements for ensuring StrategyHintVacuum
Date: 2006-09-17 22:16:23
Message-ID: 20060917221623.381E29FA435@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Marginal cleanup in arrangements for ensuring StrategyHintVacuum is cleared
after an error during VACUUM. We have a PG_TRY block anyway around the only
call sites, so just reset it in the CATCH clause instead of having
AtEOXact_Buffers blindly do it during xact end. I think the old code was
actively wrong for the case of a failure during ANALYZE inside a
subtransaction --- the flag wouldn't get cleared until main transaction end.
Probably not worth back-patching though.

Modified Files:
--------------
pgsql/src/backend/commands:
vacuum.c (r1.338 -> r1.339)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/vacuum.c.diff?r1=1.338&r2=1.339)
pgsql/src/backend/storage/buffer:
bufmgr.c (r1.209 -> r1.210)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/buffer/bufmgr.c.diff?r1=1.209&r2=1.210)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-09-17 22:50:31 pgsql: Change ANALYZE to take ShareUpdateExclusiveLock not
Previous Message User Gsmet 2006-09-16 23:15:54 pgfouine - pgfouine: changed source URL to a fixed one