Re: Buildfarm owners: check if your HEAD build is stuck

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Buildfarm owners: check if your HEAD build is stuck
Date: 2006-08-12 21:43:22
Message-ID: 20060812214322.GA23000@svana.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Aug 12, 2006 at 11:29:46AM -0400, Tom Lane wrote:
> What's happened is that that GUC patch that was in the tree for a few
> hours broke postmaster startup on some machines (for as-yet-unidentified
> reasons). The postmaster does actually start and establish its
> lockfiles, but it never gets to the stage of being able to accept
> connections.

I don't know if it's related, but coverity just started picking up a
use-after-free in parse_value() in guc.c.

At the end of the switch (case PGC_STRING) there's a free(newval)
followed by an assignment of newval to retval->stringval a few lines
further down. They mark it as line 3956 of revision 1.335.

It may not be possible though, coverity is not omnicient.

Hope this helps,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2006-08-12 21:59:37 Re: Forcing current WAL file to be archived
Previous Message David Fetter 2006-08-12 20:16:57 Re: [PATCHES] extension for sql update