Re: [PATCH] Add support for GnuTLS

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] Add support for GnuTLS
Date: 2006-05-06 18:34:45
Message-ID: 20060506183445.GD4413@svana.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Sat, May 06, 2006 at 01:11:26PM -0400, Bruce Momjian wrote:
>
> This is a pretty massive patch, but I understand the license concerns.
> Is this what we want to do?

More than half the patch is simply moving the OpenSSL related stuff
from fe/be-secure.c to fe/be-secure-openssl.c. If you create the
-openssl versions first you can more easily see that the changes are in
fact quite minor. Unfortunatly diff can't represent the change "copy N
lines from file A to file B" very efficiently.

If you like I can split it into two patches, one patch splits the openssl
stuff out of the main files and a second which adds gnutls support.

> FYI, yesterday's SSL CRL additions need to be added to this patch.

I saw them. I've already added them to my local version, including the
corresponding changes for GnuTLS. I was going to wait a few days before
sending a new version, in case any more changes came down the line.

Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-05-06 18:47:33 Re: [PATCH] Add support for GnuTLS
Previous Message Bruce Momjian 2006-05-06 17:38:48 Re: plpython improvements