Re: psql & readline & win32

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <mha(at)sollentuna(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: psql & readline & win32
Date: 2006-02-13 18:00:14
Message-ID: 200602131800.k1DI0Ej01563@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Magnus Hagander wrote:
> >> What would we patch it with? I don't think anybody has found a problem
> >> there, this is a separate file that you ship along with it.
>
> > Well, the problem is that it handles backslash incorrectly. We could
> > patch that in the readline source rather than playing with a
> > configuaration file.
>
> Do the readline developers agree that it's "incorrect"? I could see
> shipping a patch as a short-term band-aid, but not if the patch isn't
> going to be accepted upstream.

No idea. We need to develop the patch and submit it.

> >> Even that may not be enough. This is the GPL we're talking about.
>
> > At that point, psql becomes GPL, no question.
>
> Which means it's not happening, no?

To clearify, I meant the psql binary becomes GPL.

When we build psql with readline, which is our default on many
platforms, we are already be GPL'ing psql, at least according to the
copyright holders, FSF. We are dynamic linking on many platforms, but
according to the FSF, it makes it GPL.

I do think that adding readline features to the Win32 psql doesn't
warrant the license change for the psql binary.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2006-02-13 18:06:58 Re: psql & readline & win32
Previous Message Tom Lane 2006-02-13 17:52:17 Re: psql & readline & win32