Re: TODO item -- Improve psql's handling of multi-line queries

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Sergey E(dot) Koposov" <math(at)sai(dot)msu(dot)ru>
Cc: Andreas Seltenreich <uwi7(at)rz(dot)uni-karlsruhe(dot)de>, pgsql-patches(at)postgresql(dot)org
Subject: Re: TODO item -- Improve psql's handling of multi-line queries
Date: 2005-12-05 03:22:08
Message-ID: 200512050322.jB53M8X10677@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Can I have this patch in diff -c? The format you used isn't reliable
for patching. Thanks.

---------------------------------------------------------------------------

Sergey E. Koposov wrote:
> Hello,
>
> Sorry for not quick problem fixing, I was quite busy last time...
>
> I submit the new version of my patch (against the CVS tip), correcting the
> problem with \edit (pointed by Andreas). So now everything works fine.
>
> With Best Regards,
>
> Sergey
>
>
>
> On Thu, 1 Dec 2005, Bruce Momjian wrote:
>
> >
> > Where are we on this patch? Was it submitted? Applied? Just an idea?
> >
> > ---------------------------------------------------------------------------
> >
> > Andreas Seltenreich wrote:
> > > Sergey E. Koposov writes:
> > >
> > > > I'm proposing the small patch for the TODO item -- Improve psql's handling
> > > > of multi-line queries. With this patch the multi-line queries are saved
> > > > by readline as whole and not line by line.
> > >
> > > I like it already!
> > >
> > > > This is my first patch for Postgres but it seems to work and to not break
> > > > anything.
> > > >
> > > > I'm waiting for review, comments, objections, etc...
> > >
> > > Did you consider its interaction with \e? Editing the query_buffer
> > > with \e will leave that query prefixed with \e in the history. That
> > > wasn't the case before your patch.
> > >
> > > Also, using \e several times on a query without sending it (i.e.
> > > without a semicolon) will yield a history entry of a concatenation of
> > > old query buffers.
> > >
> > > Thanks,
> > > Andreas
> > >
> > > ---------------------------(end of broadcast)---------------------------
> > > TIP 4: Have you searched our list archives?
> > >
> > > http://archives.postgresql.org
> > >
> >
> >
>
>
> *****************************************************
> Sergey E. Koposov
> Max-Planck Institut for Astronomy
> Web: http://lnfm1.sai.msu.ru/~math
> E-mail: math(at)sai(dot)msu(dot)ru
>

Content-Description:

[ Attachment, skipping... ]

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-12-05 03:27:00 Re: port/snprintf.c (was Re: Numeric 508 datatype)
Previous Message Bruce Momjian 2005-12-05 03:18:10 Re: port/snprintf.c (was Re: Numeric 508 datatype)