| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Limit usage of tcop/dest.h |
| Date: | 2005-11-02 15:22:20 |
| Message-ID: | 200511021522.jA2FMKQ17622@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > So instead of changing the names of the CommandDest enum, I'm hiding it
> > from external view.
>
> I thought renaming them was a better idea, actually. A whole separate
> include file to have one forward typedef seems pretty silly. Nor am I
> convinced that you won't break some people's code by removing the rest
> of dest.h from spi.h. Finally, for anyone who *does* need to include
> dest.h, this doesn't address the underlying problem of risk of conflict
> of names.
Does the change make building PL/PHP easier?
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2005-11-02 15:30:20 | Re: pg_restore [archiver] file offset in dump file |
| Previous Message | Tom Lane | 2005-11-02 15:16:56 | Re: 8.1RC1 fails to build on OS X (10.4) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2005-11-02 15:43:03 | Re: Limit usage of tcop/dest.h |
| Previous Message | Tom Lane | 2005-11-02 14:49:50 | Re: tsearch2 makefile fixes |