From: | Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: unused variable ShmemBootstrap |
Date: | 2005-03-30 14:56:10 |
Message-ID: | 20050330145610.GA32434@dcc.uchile.cl |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
On Tue, Mar 29, 2005 at 11:48:57PM -0500, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
> > This patch removes it, along with an obsolete comment (which refers to a
> > file and function that hasn't existed at all in the whole CVS history.)
>
> I agree that the code is useless, but exactly which comment are you
> complaining of?
Oops, somehow I left that parth out of the patch.
*** shmem.c 31 Dec 2004 22:00:56 -0000 1.82
--- shmem.c 30 Mar 2005 14:56:46 -0000
***************
*** 53,61 ****
* cannot be redistributed to other tables. We could build a simple
* hash bucket garbage collector if need be. Right now, it seems
* unnecessary.
- *
- * See InitSem() in sem.c for an example of how to use the
- * shmem index.
*/
#include "postgres.h"
--- 53,58 ----
--
Alvaro Herrera (<alvherre[(at)]dcc(dot)uchile(dot)cl>)
"¿Cómo puedes confiar en algo que pagas y que no ves,
y no confiar en algo que te dan y te lo muestran?" (Germán Poo)
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2005-03-30 19:40:11 | Re: [HACKERS] contrib/pg_buffercache |
Previous Message | Neil Conway | 2005-03-30 13:53:07 | minor nodeHash cleanup |