Re: APR 1.0 released

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Zeugswetter Andreas SB SD <ZeugswetterA(at)spardat(dot)at>
Cc: Reini Urban <rurban(at)x-ray(dot)at>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: APR 1.0 released
Date: 2004-09-10 13:23:52
Message-ID: 200409101323.i8ADNri03435@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Zeugswetter Andreas SB SD wrote:
>
> > > Personally I don't think that any rename()-usleep loop is necessary.
> > > I'll check the archives.
> >
> > I agree the rename loop seems unnecessary. I kept it in case we hadn't
> > dealt with all the failure places. Should we remove them now or wait
> > for 8.1? Seems we should keep them in and see if we get reports from
> > users of looping forever, and if not we can remove them in 8.1.
>
> What I do not understand is, that Windows has rename and _unlink.
> Are we using those or not?
>
> Looping forever is certainly not good, but I thought the current code
> had a limited loop. I think a limited loop is required, since both
> rename and _unlink can not cope with a locked file.

The current code prints a log message after 30 tries but keeps trying.
We don't use the native ones because they don't work on open files
properly.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-09-10 14:04:25 Re: APR 1.0 released
Previous Message Andrew Dunstan 2004-09-10 13:08:17 Re: APR 1.0 released