Re: fix log_min_duration_statement logic error

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix log_min_duration_statement logic error
Date: 2003-10-04 02:46:43
Message-ID: 200310040246.h942khJ23270@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Thanks Peter. Patch attached. I added "(secs)" to the ouput:

LOG: duration(secs): 0.000257
LOG: duration(secs): 0.000754
LOG: duration(secs): 0.008115 select * from pg_class;

---------------------------------------------------------------------------

Peter Eisentraut wrote:
> Bruce Momjian writes:
>
> > > I think there should be just one "duration: nnn" log entry, printed if
> > > either condition holds.
> >
> > Done.
>
> Now, if I have log_statement and log_duration on, it logs each statement
> twice. The documentation says this:
>
> log_duration (boolean)
>
> Causes the duration of every completed statement to be logged. To use
> this option, enable log_statement and log_pid so you can link the
> statement to the duration using the process ID.
>
> This needs more thought.
>
> Also, please put units on all numbers.
>
> --
> Peter Eisentraut peter_e(at)gmx(dot)net
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 1.7 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2003-10-04 13:37:15 pg_id.c windows fix
Previous Message Alvaro Herrera 2003-10-04 01:28:38 more spanish updates