Re: Win32 patch to allow compilation

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Win32 patch to allow compilation
Date: 2003-05-19 17:45:55
Message-ID: 200305191745.h4JHjtJ01411@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Peter Eisentraut wrote:
> Bruce Momjian writes:
>
> > I don't think 'win' is unique enough. Win32 seems the more official
> > designation.
>
> We've lived with a "win" port for years and no one complained about that.
> And what will happen when "win64" comes around? The official designation
> is Windows anyway.

OK, I have renamed win32_include to win32. I used win32 because that is
the symbol we test for in the C code, so it seemed it made sense to be
consistent. How about MSWIN? That is more unique than win. What
symbol do we test for in the C code? __mswin__?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Jason Tishler 2003-05-19 17:49:59 Re: Cygwin PostgreSQL CVS Patch
Previous Message Tom Lane 2003-05-19 14:24:05 Re: Heads up: 7.3.3 this Wednesday